Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Continuous integration workflow #304

Draft
wants to merge 150 commits into
base: development
Choose a base branch
from

Conversation

wlsf82
Copy link
Collaborator

@wlsf82 wlsf82 commented Dec 13, 2021

This is still a work-in-progress.

Close #144

- aria-hidden hide element from screen readers
- aria-hidden should be used only if the icons have no semantic value.
- Since those icons have a meaning and are important actions to all users, we should no use aria-hidden here
@wlsf82 wlsf82 force-pushed the ci/create-continuous-integration-workflow branch from 60d32a5 to ee3a63b Compare December 13, 2021 02:01
@wlsf82
Copy link
Collaborator Author

wlsf82 commented Dec 13, 2021

@miltonbsn, I might need your help with this PR to set the GitHub secrets.

By the way, do you have any idea why we could be getting these permissions failures when trying to install the dependencies to run the end-to-end tests?

E.g.. Error: EACCES: permission denied, open '/github/home/.cache/Cypress/9.1.1/binary_state.json'

@wlsf82 wlsf82 force-pushed the ci/create-continuous-integration-workflow branch 2 times, most recently from ee3a63b to c72daf1 Compare December 13, 2021 15:59
First, it will run the unit tests, and only if they all pass, it
will run the end-to-end tests (against Chrome and Firefox.)
@wlsf82 wlsf82 force-pushed the ci/create-continuous-integration-workflow branch from c72daf1 to 258d4be Compare December 14, 2021 02:13
@idmarjr idmarjr changed the title Create a continuous integration workflow Infra: Continuous integration workflow Dec 23, 2021
miltonbsn and others added 30 commits April 22, 2024 17:15
…dule

Fix feedback messages at Models list
- Use Material icons
- Import SVG icons as components
- Add icon types at models list
- On models workspace:
   - Repalce "Model {type} of:" with its respective icon
Use icons to represent model types
- Remove styles from modelWorkspace.scss
- Move styles to it's own scss inside the component
- Import it at publicView.js
- Fix small layout issue related to navbar size on public view
After introduce the icon to represent the model type at the
model workspace header, s small aligment bug was introduced to
modelSidebar.

This commit tweak the magic numbers to fix this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add continuous integration tool (CI)
5 participants