Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add continuous integration tool (CI) #144

Closed
idmarjr opened this issue Feb 13, 2021 · 5 comments · Fixed by #254 · May be fixed by #304
Closed

Add continuous integration tool (CI) #144

idmarjr opened this issue Feb 13, 2021 · 5 comments · Fixed by #254 · May be fixed by #304
Assignees
@wlsf82
Labels
Development

Comments

@idmarjr
Copy link
Sponsor Collaborator

idmarjr commented Feb 13, 2021 •
edited

Summary

#304

In order to improve our deploy process, we want to integrate an automation tool.

This tool should check few routines like:

  • Merge from feature-branch to development.
    • If tests are OK, allow merge
  • Merge from development to master
    • If tests are OK automatically merge

Possible solutions

Output

T.B.D
@wlsf82
Copy link
Collaborator

wlsf82 commented Nov 13, 2021 •
edited by idmarjr

I've experience with the first three possible solutions, and I favor GitHub Actions since the codebase is already on GitHub.

@idmarjr
Copy link
Sponsor Collaborator Author

idmarjr commented Nov 13, 2021

Related #243

@idmarjr
Copy link
Sponsor Collaborator Author

idmarjr commented Nov 14, 2021

We're probably moving away of the branch related workflow described here:

  • Merge from feature-branch to development.
    • If tests are OK, allow merge
  • Merge from development to master
    • If tests are OK automatically merge

The idea is to have a leaner flow that remove development branch from the pipeline. At the time I'm writing this comment, the strategy is still not 100% defined. You can check #112 to know more about this.

@idmarjr
Copy link
Sponsor Collaborator Author

idmarjr commented Nov 14, 2021

@wlsf82 I'm considering keep this issue open as a aggregator for test coverage related tasks.
If this is the case, ideally we should tag #144 in pull requests adding more tests.
What you think about this?

@idmarjr idmarjr linked a pull request Nov 16, 2021 that will close this issue
Refactor existing tests and add new ones #254
Merged
@wlsf82
Copy link
Collaborator

wlsf82 commented Nov 20, 2021

@wlsf82 I'm considering keep this issue open as a aggregator for test coverage related tasks. If this is the case, ideally we should tag #144 in pull requests adding more tests. What you think about this?

This issue's description is related to CI, not really to testing.

@idmarjr idmarjr changed the title Add automate test tool Add continuous integration tool (CI) Nov 20, 2021
@idmarjr idmarjr reopened this Nov 20, 2021
@idmarjr idmarjr mentioned this issue Dec 15, 2021
Draft
@idmarjr idmarjr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlsf82 wlsf82

Labels
Development
Projects
None yet
Milestone
No milestone
2 participants
@idmarjr @wlsf82