Handle start and end date in async_get_events #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requesting events home assistant might specify a start and end date that the events returned should be between (for example, if a user has an automation that calls calendar.get_events). The previous implementation ignored these values and so would always return a full set of events. This adds simple handling of those values to skip returning events that fall outside the range. The range passed in by home assistant may include time data, but that is not handled here because we count all pickup events as taking the whole day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a python dev, so not sure this is the best way of doing this - but I made this change locally in the process of trying to set up an automation and it seems to work 馃し
When requesting events home assistant might specify a start and end date that the events returned should be between (for example, if a user has an automation that calls calendar.get_events). The previous implementation ignored these values and so would always return a full set of events. This adds simple handling of those values to skip returning events that fall outside the range.
The range passed in by home assistant may include time data, but that is not handled here because we count all pickup events as taking the whole day.