Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rev: retire -v option #581

Merged
merged 1 commit into from Apr 26, 2024
Merged

rev: retire -v option #581

merged 1 commit into from Apr 26, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 26, 2024

  • GNU rev has flags -V and --version for printing version, but on {Free,Open,Net}BSD rev has neither
  • Simplify getopts() usage by removing -v and defining VERSION_MESSAGE() which allows --version to work
  • Sync pod; --version deliberately omitted from usage string
  • Explicitly close() files so an error can be printed if this fails

@mknos
rev: retire -v option
2413404 
* GNU rev has flags -V and --version for printing version, but on {Free,Open,Net}BSD rev has neither
* Simplify getopts() usage by removing -v and defining VERSION_MESSAGE() which allows --version to work
* Sync pod; --version deliberately omitted from usage string
* Explicitly close() files so an error can be printed if this fails
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: rev The rev program labels Apr 26, 2024
@briandfoy briandfoy self-assigned this Apr 26, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 26, 2024
@briandfoy briandfoy merged commit 4c0ef0f into briandfoy:master Apr 26, 2024
1 of 2 checks passed
@briandfoy
Copy link
Owner

briandfoy commented Apr 26, 2024 •
edited

changes: remove -v option, but add it back as --version; -h and --version messages change slightly

briandfoy added a commit that referenced this pull request Apr 26, 2024
@briandfoy
Fix rev tests for new help and version messages (#581)
31a1c3b
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: rev The rev program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy