Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bc: divide by 0 #580

Merged
merged 1 commit into from Apr 26, 2024
Merged

bc: divide by 0 #580

merged 1 commit into from Apr 26, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 26, 2024

  • Catch illegal division before it happens
  • In bignum mode an error would not be thrown previously for this case; testing with is_zero() resolves this
  • I tested this in interactive mode for -b and not-b; the die() is caught so bc does not terminate---this is consistent with GNU bc

@mknos
bc: divide by 0
cd3406e 
* Catch illegal division before it happens
* In bignum mode an error would not be thrown previously for this case; testing with is_zero() resolves this
* I tested this in interactive mode for -b and not-b; the die() is caught so bc does not terminate---this is consistent with GNU bc
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: bc The bc program labels Apr 26, 2024
@briandfoy briandfoy merged commit b8e3715 into briandfoy:master Apr 26, 2024
2 checks passed
@briandfoy
Copy link
Owner

changes: catch divide by zero before we try the division

@briandfoy briandfoy self-assigned this Apr 26, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: bc The bc program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy