Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: no-match error for s/// #579

Merged
merged 1 commit into from Apr 26, 2024
Merged

ed: no-match error for s/// #579

merged 1 commit into from Apr 26, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 26, 2024

  • Difference observed when testing against GNU ed and OpenBSD ed
  • If current line doesn't contain "A", the command s/A/B is expected to generate the error "no match"
  • This error happens for searches (? and /), but not for s///
  • The logic in edSubstitute() was wrong because LastMatch assumed the current line was a positive match before the loop starts
  • The corrected version sets LastMatch only if a match occurred

@mknos
ed: no-match error for s///
f9d9f69 
* Difference observed when testing against GNU ed and OpenBSD ed
* If current line doesn't contain "A", the command s/A/B is expected to generate the error "no match"
* Currently this error is happening for ? and / searches, but not for s/// which is implemented in edSubstitute()
* The logic in edSubstitute() was wrong because LastMatch assumed the current line was a positive match before the loop starts
* The corrected version sets LastMatch only if a match occurred
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Apr 26, 2024
@briandfoy briandfoy merged commit 8019f02 into briandfoy:master Apr 26, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Apr 26, 2024
@briandfoy
Copy link
Owner

changes: s/// correctly reports "no match" for no matches.

@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy