Added support for Bucket and Object tagging and ObjectLockConfiguration #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shustinm
force-pushed
the
object_tagging
branch
3 times, most recently
from
4d27c7b
to
9a07e37
Compare
shustinm
changed the title
breuner
reviewed
May 22, 2024
shustinm
changed the title
breuner
reviewed
May 28, 2024
There was a problem hiding this comment.
thanks michael!
all comments that i made are hopefully very easy to resolve for you. would be great if you do that without any other changes in this PR, so that we can merge this and move on to another PR after this, because the number of changes in this PR is getting too big for me to throughly review.
shustinm
force-pushed
the
object_tagging
branch
2 times, most recently
from
a9cba4c
to
57e3d6b
Compare
Also added relevant arguments and a new S3 metadata phases. Co-authored-by: Erez Horev <horev.erez@gmail.com>
|
thanks for this, @shustinm & @ErezHorev ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.