Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveRecord 7.1 to appraisal and fix deprecation warning #425

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

p8
Copy link
Contributor

@p8 p8 commented Dec 13, 2023

Set the deprecation behavior on ActiveRecord.deprecator, instead of ActiveSupport::Deprecation, as that is deprecated. Fixes the following warnings:

  ActiveSupport::DeprecationException: DEPRECATION WARNING: Calling
  behavior= on ActiveSupport::Deprecation is deprecated and will be
  removed from Rails (use Rails.application.deprecators.behavior=
  instead)

Set the deprecation behavior on ActiveRecord.deprecator, instead of
ActiveSupport::Deprecation, as that is deprecated.
Fixes the following warnings:

      ActiveSupport::DeprecationException: DEPRECATION WARNING: Calling
      behavior= on ActiveSupport::Deprecation is deprecated and will be
      removed from Rails (use Rails.application.deprecators.behavior=
      instead)
@brendon brendon merged commit eef7603 into brendon:master Dec 13, 2023
1 check passed
@brendon
Copy link
Owner

brendon commented Dec 13, 2023

Thanks @p8, looks good to me! :) Merry Christmas :)

@p8 p8 deleted the rails-7.1 branch December 13, 2023 21:02
@p8
Copy link
Contributor Author

p8 commented Dec 13, 2023

Thanks @brendon 😄 Merry Christmas! 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants