Adding feature for using custom patterns #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 21, 2015 16:12
…r. Added the ability to add in a function to group/categorize tokens output by the tokenizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This branch adds:
I had the use case to use some different patterns than what shipped with the library. I also needed to capture Emoji tokens. I added new interfaces for this: PatternContext and EmojiExtractor. The DefaultPatternContext is used by default and has all of the patterns that originally shipped with the library. NoOpEmojiExtractor is used by default and will not capture Emojis.
I tested that the patch is backward compatible. Existing methods use defaults that ensure the tokens produced are the same as they are with the previous version of the library. I ran a test that processed 5,000 tweets with a fresh copy of master and then processed the same 5,000 tweets with this patch using all defaults. Both tests produced identical tokens.
Let me know if there are any problems or concerns with the patch and I will gladly address them. Thanks for the library, it has been very useful to me.
Thanks,
Steve