-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PosixPath issue with Sphinx 7.2 #964
base: main
Are you sure you want to change the base?
Conversation
Just need to cast the path to a string. Fixes breathe-doc#944
hi, I think you have the same fix but in other way in #956 |
I spoke too soon , I use this fix instead of first change on commit of #956 |
@jakobandersen sorry for the ping, but I believe you are a maintainer of Breathe -- do you think this PR would be mergeable? It's one of the main things preventing Sphinx 8.0 at the moment. A |
Actually, the fix from #956 is more complete. Notably, the tests still fail with this one, so it's not even really "testable". |
Ah, fair enough -- though I don't believe #956 will work on older versions of Sphinx, it should use the A |
Are you asking me to open a fourth competing pull request? ;-) |
I be clear I use this one, more [1] found in #956 [1]
|
Just need to cast the path to a string.
Fixes #944