Feat: Add bank validations #224

mateusbw · 2021-05-18T02:52:07Z

As requested on #171, this PR adds validation to the following banks:

Banco do Brasil, Santander, CEF, Bradesco, Itau, Real, HSBC, Citibank

The validations goes according to this provided documentation
http://177.153.6.25/ercompany.com.br/boleto/laravel-boleto-master/manuais/Regras%20Validacao%20Conta%20Corrente%20VI_EPS.pdf

hyanmandian · 2021-05-19T14:22:06Z

Hello @mateusbw . We are very happy with your first contribution to our library! I gonna review your code as soon as I have time available.

Thanks!

diasbruno · 2021-10-25T14:17:03Z

src/utilities/conta-bancaria/validators/bancoDoBrasil.ts

+  }
+
+  private getAccountVerificationDigit(accountNumber:string){
+    const digitSum = accountNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (9-index),0);


Suggested change

const digitSum = accountNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (9-index),0);

const digitSum = accountNumber.split("").reduce((acc, digit, index) => acc + parseInt(digit) * (9-index), 0);

diasbruno · 2021-10-25T14:17:39Z

src/utilities/conta-bancaria/validators/bradesco.ts

+ }
+
+ private getAccountVerificationDigit(accountNumber:string){
+   const digitSum = accountNumber.split("").reverse().map(Number).reduce((acc,cur,index)=> acc + cur * ((index%7+2)),0);


Suggested change

const digitSum = accountNumber.split("").reverse().map(Number).reduce((acc,cur,index)=> acc + cur * ((index%7+2)),0);

const digitSum = accountNumber.split("").reverse().reduce((acc, digit, index)=> acc + parseInt(digit) * ((index%7+2)), 0);

diasbruno · 2021-10-25T14:18:23Z

src/utilities/conta-bancaria/validators/caixaEconomicaFederal.ts

+  }
+
+  private getAccountVerificationDigit(accountNumber:string, agencyNumber:string, accountType: string){
+    const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (8 - index),0);


Suggested change

const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (8 - index),0);

const agencySum = agencyNumber.split("").reduce((acc, digit, index)=> acc + parseInt(digit) * (8 - index), 0);

diasbruno · 2021-10-25T14:18:43Z

src/utilities/conta-bancaria/validators/caixaEconomicaFederal.ts

+
+  private getAccountVerificationDigit(accountNumber:string, agencyNumber:string, accountType: string){
+    const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (8 - index),0);
+    const accountTypeSum = accountType.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (4 - index),0);


Suggested change

const accountTypeSum = accountType.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (4 - index),0);

const accountTypeSum = accountType.split("").reduce((acc, digit, index)=> acc + parseInt(digit) * (4 - index),0);

diasbruno · 2021-10-25T14:19:38Z

src/utilities/conta-bancaria/validators/caixaEconomicaFederal.ts

+  private getAccountVerificationDigit(accountNumber:string, agencyNumber:string, accountType: string){
+    const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (8 - index),0);
+    const accountTypeSum = accountType.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (4 - index),0);
+    const accountNumberSum = accountNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (9 - index),0);


Suggested change

const accountNumberSum = accountNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (9 - index),0);

const accountNumberSum = accountNumber.split("").reduce((acc, digit, index) => acc + parseInt(digit) * (9 - index), 0);

diasbruno · 2021-10-25T14:20:10Z

src/utilities/conta-bancaria/validators/citibank.ts

+ }
+
+  private getAccountVerificationDigit(accountNumber:string, agencyNumber:string){
+    const sum = `${agencyNumber}${accountNumber}`.split("").map(Number).reduce((acc,cur,index) => acc + cur * (11-index),0);


Suggested change

const sum = `${agencyNumber}${accountNumber}`.split("").map(Number).reduce((acc,cur,index) => acc + cur * (11-index),0);

const sum = `${agencyNumber}${accountNumber}`.split("").reduce((acc, digit,index) => acc + parseInt(digit) * (11-index),0);

diasbruno · 2021-10-25T14:20:36Z

src/utilities/conta-bancaria/validators/hsbc.ts

+ }
+
+  private getAccountVerificationDigit(accountNumber:string, agencyNumber:string){
+    const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index) => acc + cur * this.agencyMultiplicationWeights[index],0);


Suggested change

const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index) => acc + cur * this.agencyMultiplicationWeights[index],0);

const agencySum = agencyNumber.split("").reduce((acc,digit,index) => acc + parseInt(digit) * this.agencyMultiplicationWeights[index],0);

diasbruno · 2021-10-25T14:20:59Z

src/utilities/conta-bancaria/validators/hsbc.ts

+
+  private getAccountVerificationDigit(accountNumber:string, agencyNumber:string){
+    const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index) => acc + cur * this.agencyMultiplicationWeights[index],0);
+    const accountSum = accountNumber.split("").map(Number).reduce((acc,cur,index) => acc + cur * (index + 4),0);


Suggested change

const accountSum = accountNumber.split("").map(Number).reduce((acc,cur,index) => acc + cur * (index + 4),0);

const accountSum = accountNumber.split("").reduce((acc,digit,index) => acc + parseInt(digit) * (index + 4), 0);

diasbruno · 2021-10-25T14:21:45Z

src/utilities/conta-bancaria/validators/itau.ts

+    const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur, index)=> {
+      const digitMultiplication = cur * (isEven(index + 1)? 1 : 2)


Suggested change

const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur, index)=> {

const digitMultiplication = cur * (isEven(index + 1)? 1 : 2)

const agencySum = agencyNumber.split("").reduce((acc, digit, index)=> {

const digitMultiplication = parseInt(digit) * (isEven(index + 1)? 1 : 2)

diasbruno · 2021-10-25T14:22:14Z

src/utilities/conta-bancaria/validators/itau.ts

+    const accountNumberSum = accountNumber.split("").map(Number).reduce((acc,cur, index)=> {
+      const digitMultiplication = cur * (isEven(index + 1)? 1 : 2)


Suggested change

const accountNumberSum = accountNumber.split("").map(Number).reduce((acc,cur, index)=> {

const digitMultiplication = cur * (isEven(index + 1)? 1 : 2)

const accountNumberSum = accountNumber.split("").reduce((acc, digit, index)=> {

const digitMultiplication = parseInt(digit) * (isEven(index + 1)? 1 : 2)

diasbruno · 2021-10-25T14:23:13Z

src/utilities/conta-bancaria/validators/itau.ts

+    return number
+    .toString()
+    .split('')
+    .map(Number)


Suggested change

.map(Number)

diasbruno · 2021-10-25T14:23:27Z

src/utilities/conta-bancaria/validators/itau.ts

+    .toString()
+    .split('')
+    .map(Number)
+    .reduce((a, b) => a + b, 0);


Suggested change

.reduce((a, b) => a + b, 0);

.reduce((a, b) => parseInt(a) + parseInt(b), 0);

diasbruno · 2021-10-25T14:23:46Z

src/utilities/conta-bancaria/validators/real.ts

+ }
+
+  private getAccountVerificationDigit(accountNumber:string, agencyNumber:string){
+    const sum = `${agencyNumber}${accountNumber}`.split("").map(Number).reduce((acc,cur,index) => acc + cur * this.multiplicationWeights[index],0);


Suggested change

const sum = `${agencyNumber}${accountNumber}`.split("").map(Number).reduce((acc,cur,index) => acc + cur * this.multiplicationWeights[index],0);

const sum = `${agencyNumber}${accountNumber}`.split("").reduce((acc,digit,index) => acc + parseInt(digit) * this.multiplicationWeights[index],0);

diasbruno · 2021-10-25T14:24:14Z

src/utilities/conta-bancaria/validators/santander.ts

+ }
+
+ private getAccountVerificationDigit(accountNumber:string, agencyNumber:string){
+  const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index)=> acc + this.getLastDigit(cur * this.agencyMultypliers[index]),0);


Suggested change

const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index)=> acc + this.getLastDigit(cur * this.agencyMultypliers[index]),0);

const agencySum = agencyNumber.split("").reduce((acc,digit,index)=> acc + this.getLastDigit(parseInt(digit) * this.agencyMultypliers[index]),0);

diasbruno · 2021-10-25T14:24:32Z

src/utilities/conta-bancaria/validators/santander.ts

+
+ private getAccountVerificationDigit(accountNumber:string, agencyNumber:string){
+  const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index)=> acc + this.getLastDigit(cur * this.agencyMultypliers[index]),0);
+  const accountSum = accountNumber.split("").map(Number).reduce((acc,cur,index)=> acc + this.getLastDigit(cur * this.accountMultypliers[index]),0);


Suggested change

const accountSum = accountNumber.split("").map(Number).reduce((acc,cur,index)=> acc + this.getLastDigit(cur * this.accountMultypliers[index]),0);

const accountSum = accountNumber.split("").reduce((acc,digit,index)=> acc + this.getLastDigit(parseInt(digit) * this.accountMultypliers[index]),0);

hyanmandian · 2021-10-25T15:52:48Z

Nice job doing code review @diasbruno ! Hey @mateusbw can you check @diasbruno suggestions?

mateusbw · 2021-10-25T15:54:02Z

Thanks for the review @diasbruno!! @hyanmandian sure, i'll do that!!

diasbruno · 2021-10-25T16:03:37Z

Glad to help!

Also, and this is the big one,...In OOP, we only instantiate object of classes if we are encapsulating data and providing behavior. Since the only method isValid is used and all the data it uses are external to the object, maybe providing just the function isValid can simplify things.

diasbruno · 2021-10-25T16:24:14Z

src/utilities/conta-bancaria/__tests__/bancoBanrisul.test.ts

@@ -0,0 +1,12 @@
+import { BankValidator } from "./bankValidator";


This is an implementation, not a test.

diasbruno · 2021-10-25T16:31:35Z

src/utilities/conta-bancaria/index.ts

+ */
+export function isValidAccount(bankCode:BankCode, accountNumber: string, agencyNumber?: string) {
+  const bank = new BANKS[bankCode]();
+  return bank.isValid(accountNumber, agencyNumber);


There are a lot of more banks in Brazil...It would be nice to provide something where we can add more banks to BANKS.

addBankValidator(BankCode, Validator);

I dont know if we need that... I think if some bank appears and we don't have support for it, we just can integrate and publish another library version, probably if someone needs that and we don't have it, they can open an issue telling that to us and we just add it. What do you think about it?

This is the only case where I'm a pessimist...It's more likely that people will implement on their end and don't make a PR. 😞

So, it'd be nice to have that, but it's not mandatory.

Add bank validations

9b6641a

diasbruno reviewed Oct 25, 2021

View reviewed changes

src/utilities/conta-bancaria/validators/itau.ts

return number

.toString()

.split('')

.map(Number)

Copy link

diasbruno Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

.map(Number)

diasbruno reviewed Oct 25, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Add bank validations #224

Feat: Add bank validations #224

mateusbw commented May 18, 2021

hyanmandian commented May 19, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

hyanmandian commented Oct 25, 2021

mateusbw commented Oct 25, 2021

diasbruno commented Oct 25, 2021

diasbruno Oct 25, 2021

diasbruno Oct 25, 2021

hyanmandian Oct 26, 2021

diasbruno Oct 26, 2021 •

edited

	const digitSum = accountNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (9-index),0);
	const digitSum = accountNumber.split("").reduce((acc, digit, index) => acc + parseInt(digit) * (9-index), 0);

	const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (8 - index),0);
	const agencySum = agencyNumber.split("").reduce((acc, digit, index)=> acc + parseInt(digit) * (8 - index), 0);

	const accountTypeSum = accountType.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (4 - index),0);
	const accountTypeSum = accountType.split("").reduce((acc, digit, index)=> acc + parseInt(digit) * (4 - index),0);

	const accountNumberSum = accountNumber.split("").map(Number).reduce((acc,cur,index)=> acc + cur * (9 - index),0);
	const accountNumberSum = accountNumber.split("").reduce((acc, digit, index) => acc + parseInt(digit) * (9 - index), 0);

	const sum = `${agencyNumber}${accountNumber}`.split("").map(Number).reduce((acc,cur,index) => acc + cur * (11-index),0);
	const sum = `${agencyNumber}${accountNumber}`.split("").reduce((acc, digit,index) => acc + parseInt(digit) * (11-index),0);

	const accountSum = accountNumber.split("").map(Number).reduce((acc,cur,index) => acc + cur * (index + 4),0);
	const accountSum = accountNumber.split("").reduce((acc,digit,index) => acc + parseInt(digit) * (index + 4), 0);

		const agencySum = agencyNumber.split("").map(Number).reduce((acc,cur, index)=> {
		const digitMultiplication = cur * (isEven(index + 1)? 1 : 2)

	.reduce((a, b) => a + b, 0);
	.reduce((a, b) => parseInt(a) + parseInt(b), 0);

		@@ -0,0 +1,12 @@
		import { BankValidator } from "./bankValidator";

Feat: Add bank validations #224

Are you sure you want to change the base?

Feat: Add bank validations #224

Conversation

mateusbw commented May 18, 2021

hyanmandian commented May 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyanmandian commented Oct 25, 2021

mateusbw commented Oct 25, 2021

diasbruno commented Oct 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diasbruno Oct 26, 2021 • edited

Choose a reason for hiding this comment

diasbruno Oct 26, 2021 •

edited