Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/placa renavam #138

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

eduardo-fernandes-marques

Adicionado features de validação:

Renavam
Placa de veículo (Carro, Carro Mercosul, Moto Mercosul)

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #138 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        52    +2     
  Lines          932       963   +31     
  Branches       111       117    +6     
=========================================
+ Hits           932       963   +31     
Impacted Files Coverage Δ
src/utilities/index.ts 100.00% <100.00%> (ø)
src/utilities/plate/index.ts 100.00% <100.00%> (ø)
src/utilities/renavam/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8813c7...0e6fd4d. Read the comment docs.

Copy link
Member

@hyanmandian hyanmandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/utilities/index.ts Outdated Show resolved Hide resolved
src/utilities/renavam/index.ts Outdated Show resolved Hide resolved
src/utilities/renavam/index.ts Outdated Show resolved Hide resolved
src/utilities/renavam/index.ts Outdated Show resolved Hide resolved
@hyanmandian
Copy link
Member

Ola @eduardo-fernandes-marques acabamos de mergear #158 que tem a ver com o teu e notamos uma divergencia de implementações, queria ver contigo se tu ve algo a acrescentar já que o teu possui mais implementações do que o código que foi mergeado.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants