Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CO-2414] Add documentation for price drop notifications for catalogs - EA #7011

Merged
merged 10 commits into from Apr 2, 2024

Conversation

Vector919
Copy link
Contributor

@Vector919 Vector919 commented Mar 7, 2024

Description of Change:

New hidden doc for the catalog price drop notifications feature

Is this change associated with a Braze feature/product release?

  • Yes
  • No

@cla-bot cla-bot bot added the cla-signed label Mar 7, 2024
@lydia-xie lydia-xie added the status: on hold / do not merge Could mean research before "in progress" status, or do not merge yet. label Mar 7, 2024
@raghavnarain3
Copy link
Contributor

we should explicitly say it does not work for shopify customers

@lydia-xie lydia-xie requested review from lydia-xie and removed request for a team March 11, 2024 15:24
…/price_drop_notifications.md

Co-authored-by: Dave Hensley <david.hensley@braze.com>
Copy link

@marisak marisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple nits, but looks great otherwise! Excited to get these docs in!

@lydia-xie lydia-xie changed the title [DO NOT MERGE][CO-2414] Adding documentation for Catalogs: Price Drop [CO-2414] Adding documentation for Catalogs: Price Drop Apr 2, 2024
@lydia-xie lydia-xie changed the title [CO-2414] Adding documentation for Catalogs: Price Drop [CO-2414] Add documentation for price drop notifications for catalogs Apr 2, 2024
@lydia-xie lydia-xie changed the title [CO-2414] Add documentation for price drop notifications for catalogs [CO-2414] Add documentation for price drop notifications for catalogs - EA Apr 2, 2024
@lydia-xie
Copy link
Contributor

lydia-xie commented Apr 2, 2024

Made a few edits to align with our style guide and updated the article to be hidden. I got approval from @johndinh to merge this PR. Thanks @Vector919 for putting this all together! 👍

@lydia-xie lydia-xie merged commit cf62cfc into develop Apr 2, 2024
2 checks passed
@lydia-xie lydia-xie deleted the CO-2414-price-drop-documentation branch April 2, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed status: on hold / do not merge Could mean research before "in progress" status, or do not merge yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants