Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BRA-4724): Video playback hls with headers on safari #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magacao
Copy link
Collaborator

@magacao magacao commented Feb 14, 2024

Description

The condition shouldUseHlsLibrary would prevent safari from passing xhr headers because canPlayHlsNatively is true.

We now use canPlayHlsNatively to listen to the correct event to load the data.

          _videoElement.onCanPlay.listen((dynamic _) {

Does not work on safari. We have to use

          _videoElement.addEventListener('durationchange', (_) {

Also the videoElement.size is always 0. See this issue: flowplayer/flowplayer#1228. So we need to hardcode values on safari. I tried using the addEventListener on canplaythrough but it didn't work.

Copy link

linear bot commented Feb 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant