Ensure all exceptions are retried. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-superlist
force-pushed
the
bugfix/70-handle-unexpected-exceptions
branch
from
b7e4ae0
to
0723f34
Compare
brian-superlist
force-pushed
the
bugfix/70-handle-unexpected-exceptions
branch
4 times, most recently
from
28ac05e
to
9d39171
Compare
brian-superlist
force-pushed
the
bugfix/70-handle-unexpected-exceptions
branch
from
9d39171
to
b443909
Compare
brian-superlist
commented
Mar 6, 2024
|
Thanks! It's part of the just released 0.7.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70.
This PR ensures that if non-
PhoenixExceptionexceptions are raised when attempting to send the heartbeat, the socket will attempt to reconnect. This should fix one case where the socket is left in a "broken" state, where it stops scheduling reconnects and cannot be connected to manually.As part of this PR, I also renamed any tests that were hitting a real backend as an
_integration_test, since it is a true integration test against a backend, not a unit test that can rely on mocks. I can also go the other way, calling the new socket test asocket_unit_test.dartif that's preferred. I don't feel strongly, but I think it's important not to mix the two tests, as the integration tests are run on CI but harder to run locally.