Skip to content

Commit

Permalink
Don't rethrow. Stops the periodic timer.
Browse files Browse the repository at this point in the history
  • Loading branch information
brianegan committed Mar 7, 2024
1 parent f23ebb7 commit b1213ad
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions lib/src/socket.dart
Original file line number Diff line number Diff line change
Expand Up @@ -456,19 +456,15 @@ class PhoenixSocket {
),
));

// Rethrow instead of returning false to ensure WebSocketChannelException
// is propagated to the call site.
rethrow;
return false;
} catch (err, stacktrace) {
_logger.severe(
'[phoenix_socket] Heartbeat message failed',
err,
stacktrace,
);

// Rethrow instead of returning false to ensure the underlying
// exception is propagated to the call site.
rethrow;
return false;
}
}

Expand Down

0 comments on commit b1213ad

Please sign in to comment.