Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LCX001 #2213

Merged
merged 5 commits into from May 18, 2024
Merged

Add LCX001 #2213

merged 5 commits into from May 18, 2024

Conversation

nonamejuju
Copy link
Contributor

Adding measurement for Philips Hue LCX001

Copy link
Contributor

github-actions bot commented Apr 21, 2024

Thank you for submitting light measurements!
Here are some visualizations for the CSV files.

Image
Image

Copy link
Owner

@bramstroker bramstroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. measurements look good.

custom_components/powercalc/data/signify/LCX001/model.json Outdated Show resolved Hide resolved
@bramstroker
Copy link
Owner

Could you check "supported color modes" of your light please.
See the questions in the PR template: https://github.com/bramstroker/homeassistant-powercalc/blob/master/.github/PULL_REQUEST_TEMPLATE/power_profile.md

Also please share the manufacturer / model which is in the left top of device page in HA.

@nonamejuju
Copy link
Contributor Author

nonamejuju commented Apr 27, 2024 via email

@bramstroker
Copy link
Owner

Thanks, that means also measurements for color_temp needs to be provided.
As we need to make sure the power profile also works when a user switches the light to color temperature mode.

You can add 929002422702 to aliases in model.json.
That will make autodiscovery work correctly.

@nonamejuju
Copy link
Contributor Author

Thanks. Will do the measurement tomorow.

@nonamejuju
Copy link
Contributor Author

Uploaded color_temp measurement, should be good now

@bramstroker
Copy link
Owner

Looking at the visualizations it seems power consumption stays the same starting from brightness level 60.
Could you please verify this?
Color measurements are hitting the 20W mark, which I would also expect here on max brightness level.

New measurement
@nonamejuju
Copy link
Contributor Author

Updated the color_temp measurement this one is hitting the 20W mark. Don't know what happen to previous one 🤷‍♀️

@bramstroker
Copy link
Owner

@nonamejuju Things are looking fine now. Thanks!

@bramstroker
Copy link
Owner

Sorry, I want to merge, but I see directory structure is not correct yet.

You have submitted the files in two directories. And the files should be in profile_library now, not custom_components/powercalc/data anymore.
I will checkout your PR and fix it.

Screenshot 2024-05-18 at 09 09 05

@bramstroker bramstroker merged commit ffed0d4 into bramstroker:master May 18, 2024
7 of 8 checks passed
@nonamejuju
Copy link
Contributor Author

Thanks for the merge, but I think we forget the alias for the light "929002422702", curently there is no autodiscovery of the lamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants