Allow using the public github api #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two changes are needed: * rate limit such that github doesn't ratelimit heckler * allow passing an empty "github_domain" to the config to use the public API endpoints
ClashTheBunny
force-pushed
the
allow_public_api
branch
from
672a70d
to
aebb10a
Compare
Merged
| @@ -2735,7 +2741,14 @@ func fetchRepo(conf *HecklerdConf) (*git.Repository, error) { | |||
| Url: conf.GitHubHttpProxy, | |||
| } | |||
| } | |||
| remoteUrl := fmt.Sprintf("https://x-access-token:%s@%s/%s/%s", tok, conf.GitHubDomain, conf.RepoOwner, conf.Repo) | |||
There was a problem hiding this comment.
May be we Could we move this "empty" check to main function. There is logic to setup default values and checking if values are empty or not. [We can keep all config default/empty check logics at one place.
There was a problem hiding this comment.
Yeah, this felt gross to me too. That's a great suggestion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes are needed: