Release braintree-web 3.99.2 source

Co-authored-by: Joe Plukarski <jplukarski@paypal.com>

CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG
 
+# 3.99.2
+
+- Venmo
+  - Fix race condition in previous bug fix.
+
 # 3.99.1
 
 - Venmo

package.json

@@ -1,6 +1,6 @@
 {
   "name": "braintree-web",
-  "version": "3.99.1",
+  "version": "3.99.2",
   "license": "MIT",
   "main": "src/index.js",
   "private": true,

src/venmo/shared/web-login-backdrop.js

@@ -58,25 +58,26 @@ function openPopup(options) {
           extendedPromise.resolve(data);
         })
         .catch(function (statusCheckError) {
-          extendedPromise.reject(statusCheckError);
+          // We add this check here because at this point
+          // the status should not be in CREATED status.
+          // However, there is an edge case where if a buyer
+          // cancels in the popup, the popup might close itself
+          // before it can send the graphQL mutation to update its status.
+          // In these cases, the status will be stuck in CREATED status, and
+          // tokenization would fail, incorrectly throwing a tokenization error
+          // instead of informing the merchant that the customer canceled.
+          checkPaymentContextStatus().then(function (node) {
+            if (node.status === "CREATED") {
+              extendedPromise.reject(
+                new BraintreeError(errors.VENMO_CUSTOMER_CANCELED)
+              );
+            } else {
+              extendedPromise.reject(statusCheckError);
+            }
+          });
         });
     }
 
-    // We add this check here because at this point
-    // the status should not be in CREATED status.
-    // However, there is an edge case where if a buyer
-    // cancels in the popup, the popup might close itself
-    // before it can send the graphQL mutation to update its status.
-    // In these cases, the status will be stuck in CREATED status, and
-    // tokenization would fail, incorrectly throwing a tokenization error
-    // instead of informing the merchant that the customer canceled.
-    checkPaymentContextStatus().then(function (status) {
-      if (status === "CREATED") {
-        extendedPromise.reject(
-          new BraintreeError(errors.VENMO_CUSTOMER_CANCELED)
-        );
-      }
-    });
     frameServiceInstance.close();
     closeBackdrop();
   });

test/venmo/unit/web-login-backdrop.js

@@ -319,6 +319,7 @@ describe("web-login-backdrop", () => {
       const expectedRejectedValue = "some err";
 
       mockStatusCheck.mockRejectedValue(expectedRejectedValue);
+      mockPaymentContextStatus.mockResolvedValue({ status: "FAILED" });
 
       await openPopup(openOptions).catch((err) => {
         expect(err).toBe(expectedRejectedValue);