Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Fix jumpy animation with SwiftUI #320

Closed
wants to merge 6 commits into from
Closed

Conversation

sestevens
Copy link
Contributor

Summary of changes

From what I can tell, the jumpy animation is the result of adjusting the top constraint on the content view (which contains the payment selection sheet) in BTDropInController's viewDidAppear method. To fix this, I removed the top constraint and set a height constraint instead. Previously, we were animating the top and bottom constraints to make the payment selection sheet slide up from the bottom of the screen. Instead, we can keep the height constraint constant during the animation and animate the bottom constraint only.

To do

  • Fix spinner sliding in from the top left when the payment selection sheet appears (it should just be in the middle of the sheet)
  • Fix layout in SwiftUI demo (for some reason the Drop-in is not extending to the bottom of the screen)

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sestevens sestevens changed the title Fix jumpy animation with SwiftUI [DRAFT] Fix jumpy animation with SwiftUI Apr 23, 2021
@jaxdesmarais
Copy link
Contributor

Closing this PR since we haven't touches it in 3 years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants