[DRAFT] Fix jumpy animation with SwiftUI #320
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
From what I can tell, the jumpy animation is the result of adjusting the top constraint on the content view (which contains the payment selection sheet) in
BTDropInController
'sviewDidAppear
method. To fix this, I removed the top constraint and set a height constraint instead. Previously, we were animating the top and bottom constraints to make the payment selection sheet slide up from the bottom of the screen. Instead, we can keep the height constraint constant during the animation and animate the bottom constraint only.To do
Checklist
Authors