-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contactsheets for 3D-slices behave as 3D-surfaces #706
Contactsheets for 3D-slices behave as 3D-surfaces #706
Conversation
@tmedani, @chinmaychinara91 could you provide some feedback on this PR. |
Open Default Anatomy MRI > Right click > Snapshot > Choose any of the View contact sheet and choose the defaults from Contact sheet GUI. Getting the error below:
|
@chinmaychinara91 Good catch, I forgot the calls from the MRI viewer |
all looks good to me, |
One comment: is it better to have just one color bar? |
@tmedani, it is possible that the maximum of the colormap is set to @chinmaychinara91, commit 94f5313 handles the case you found. How about now? |
I see, so it is then easier to tune each figure locally. The thing that bothers me is the size of the figure, which is much smaller. |
@rcassani looks good now. |
This bothered as well. It has now been addressed! |
Awesome :) |
Ok, this is now ready. One of the changes, is that all contactsheets are obtained from 3D figures, even when initiated from the MRI viewer. This is to handle the time legend and colorbar. Also the removal of the useless black background is now done across all the contact images, so the final composite image can be cut into equal size pieces, and all the pieces have the same spatial scale. This was not possible before as the removal was different for each (contact) image. |
This PR has as goal to have the same functionality in ContactSheets for 3D figures: MRI slices and surfaces. The difference was reported in this Forum thread:
https://neuroimage.usc.edu/forums/t/45757/10
With these changes, contact sheets from 3D MRI slices will now have:
These two elements will be hidden (as the current behaviour) if and only if there is not data (sources and TF) plotted on the MRI slices, AND volume contact sheets are requested.
For MRI slices: contactsheet
Time
withData
(source values)For MRI slices: contactsheet
Volume
without DataEDIT: Images have been updated to current state of PR