Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix when display scout time series with a time series already open #705

Merged
merged 1 commit into from
May 14, 2024

Conversation

Edouard2laire
Copy link
Contributor

@Edouard2laire Edouard2laire commented May 10, 2024

Hello,

This fix a bug that has been annoying me for years :)

To reproduce:

  • open a reconstruction map on the cortex
  • Visualize one timecourse from a ROI
  • open another map
  • click on the visualize time-course button. (with Files overlay selected)

The second visualize time-course click results in an error if you don't close the previously opened time course. This PR fixes that and allows adding a new time course in the window without closing it first.

Here is the error that get fixed:

***************************************************************************
** Error: Line 63:  strcmp
** Inputs must be the same size or either one can be a scalar.
** 
** Call stack:
** >file_compare.m at 63
** >bst_figures.m>CreateFigure at 148
** >bst_figures.m at 59
** >view_timeseries_matrix.m at 152
** >view_scouts.m at 662
** >panel_scout.m>ViewTimeSeries at 3790
** >bst_call.m at 28
** >panel_scout.m>@(h,ev)bst_call(@ViewTimeSeries) at 91
** 
***************************************************************************

The only eventual issue with this fix, is that it is opening a new time-course viewer instead of reusing the previous one; but I guess this is better than an error :)

@rcassani rcassani merged commit f1cfa1c into brainstorm-tools:master May 14, 2024
@rcassani
Copy link
Member

@Edouard2laire, The proposed change was merged, as it could improve the comparison of file cells when different size.


However, regarding the bug, I tried with the steps above, and the second click opens a new time-series figure with two time series: Scout-File1 in green and Scout-File2 in red.
For the steps 2, I'm using the button iconTSDisplay in the Scout tab.

@Edouard2laire
Copy link
Contributor Author

Edouard2laire commented May 14, 2024

tried with th

However, regarding the bug, I tried with the steps above, and the second click opens a new time-series figure with two time series: Scout-File1 in green and Scout-File2 in red.
For the steps 2, I'm using the button iconTSDisplay in the Scout tab.

yes, me too. Did you selected file overlay in the time-series option ?

@Edouard2laire Edouard2laire deleted the view_time_series branch May 14, 2024 21:34
@rcassani
Copy link
Member

yes, me too. Did you selected file overlay in the time-series option ?

Yup. Tried with links and with full source maps. With files with same Comment and with different one.
All my tests where in the master branch, I guess yours as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants