Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Digitize panel #682

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Moo-Marc
Copy link
Collaborator

@Moo-Marc Moo-Marc commented Feb 14, 2024

This adds a new version of the Digitize panel, in parallel to the current version.
Main changes:

  • Added settings:
    • set of fiducials to digitize, allowing e.g. a 4th MEG head coil.
    • Polhemus device configuration commands, e.g. "hemisphere of operation"
    • Distance threshold for warning message
  • Large display of next point to digitize, to be visible away from the desk
  • Added "beep" and more visible error message when repeated measures > 5mm (default distance threshold)
  • New button to add a set of fiducials to be digitized at any moment, e.g. at end to confirm receiver didn't move and points are good
  • Uses serialport instead of serial (no more warnings), but requires R2019 or newer.
  • Help menu linking to Digitize tutorial
  • New menu item to switch versions of the panel: original or 2024. The panel closes and must be reopened after switching.
  • Now always uses anatomical fiducials to convert coordinates to SCS. Original version saved them in system defined by MEG coils when present, and Brainstorm would convert to anatomically defined SCS when importing.
  • "Delete last point" button replaced by "Start over" until all initial fiducials are digitized.

digitize_2024 digitize_2024_warning
digitize_2024_settings

The tutorial is not yet updated.
This version is now installed in our lab to use for a while before merging. Others may want to test it also. (@tmedani?)

@Moo-Marc
Copy link
Collaborator Author

For Brainstorm "news", we could describe the main advantages as:
New Digitize version: can recheck fiducials, supports more fids, customizable device config, improved GUI

@Moo-Marc
Copy link
Collaborator Author

Brainstorm doesn't deal correctly with points saved in SCS. So I'll revert to saving them in coil-based coordinates in the new version. But I'll also try to fix Bst so any "native" coordinates are treated correctly when importing pos files. This will have the added advantage that if we need to manually edit the coordinates of head coils (e.g. they were digitized in wrong order), it will still import correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant