fix: enumerize with string store accessor keys #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nashby, when you get a chance, can you please take a look at this bug fix as well? I think @4ndypanda might need to resolve a conflict, but it looks otherwise good to go! |
4ndypanda
force-pushed
the
ricksong/fix-store-attributes
branch
3 times, most recently
from
10d19da
to
816767f
Compare
|
Note to self, rebase after merging #450. |
Ensures Enumerize is agnostic to whether the key to a store accessor is a string or symbol
4ndypanda
force-pushed
the
ricksong/fix-store-attributes
branch
from
816767f
to
2957576
Compare
|
@4ndypanda thanks! I pushed a small change c77d0e3 since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures Enumerize is agnostic to whether the key to a store accessor is a string or symbol.
Re-opening #405 but with fix to not generate string objects with
#to_sfrom original PR. Because ActiveRecord::Store's.storeand.store_accessormethods allow string names for attribute names, we should be able to handle them. This has come up for me when dealing with meta-programming where one dynamically defines store attributes.