Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MDMS method and examples #413

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add MDMS method and examples #413

wants to merge 7 commits into from

Conversation

hejiaz
Copy link
Contributor

@hejiaz hejiaz commented Feb 26, 2019

Add multi-dataset multi-subject (MDMS) SRM analysis method and two example files.

@hejiaz hejiaz changed the title Add MDMS method and examples WIP: Add MDMS method and examples Feb 26, 2019
@hejiaz hejiaz changed the title WIP: Add MDMS method and examples Add MDMS method and examples Feb 27, 2019
@hejiaz
Copy link
Contributor Author

hejiaz commented Feb 27, 2019

The pr-check finished successfully on my computer and Princeton Adroit cluster, but the Travis CI build couldn't complete here. It says "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself." Also, I don't have the permission to view the output from the Jenkins linux build, so I don't know what happened there.

@hejiaz
Copy link
Contributor Author

hejiaz commented Feb 27, 2019

Could anyone take a look?

@lcnature
Copy link
Contributor

The linux failure seems to be related to failure of installying scipy... Not sure why. I think it is unrelated to your code.

@hejiaz
Copy link
Contributor Author

hejiaz commented Feb 28, 2019

The Travis CI build couldn't complete. It says "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself." Did anyone have the same issue before? Is there a way to workaround or ask it to build again with the same code?

@mihaic
Copy link
Member

mihaic commented Feb 28, 2019

Any of the @brainiak/committers can restart Travis builds from the Travis website.

@hejiaz
Copy link
Contributor Author

hejiaz commented Mar 1, 2019

I checked my permission status and it turns out I don't have the write access to this repo, so I can't restart the build (I couldn't click the restart build button or restart from the console).

@mihaic
Copy link
Member

mihaic commented Mar 4, 2019

@hejiaz, I'm sorry I was not clear in my previous comment. I didn't mean that you should be able to restart the build, I meant the member of the committers team.

I can build your branch on my computer. I'll investigate the Travis issue. In the meantime, we should get a review. If no one volunteers, can you suggest someone?

@hejiaz
Copy link
Contributor Author

hejiaz commented Mar 4, 2019

@mihaic Thank you! I suggest Mingbo @lcnature as the reviewer.

@mihaic
Copy link
Member

mihaic commented Feb 24, 2020

@hejiaz, @lcnature, could you please have another look at this PR?

@lcnature
Copy link
Contributor

@hejiaz @mihaic Sorry. It was my fault. I will catch up asap

change `np.int` to `np.int32` to conform to update of numpy.
correct formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants