Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Parse numbers from string by default and add 'noParseNumbers' option … #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ralphilius
Copy link

…as recommended in #7

@adriens
Copy link

adriens commented Feb 16, 2018

Hi guys, any chance to get this feature soon please ?

@adriens
Copy link

adriens commented Feb 16, 2018

I've tested the patch and it does perfectly does the job, thanks a lot @ralphilius 👍

@adriens
Copy link

adriens commented Feb 16, 2018

Please merge this PR so i can switch back to this repo 🙏

@rcourtna
Copy link

Works well for my needs, thanks!

@dandaka
Copy link

dandaka commented Feb 13, 2019

Works bad with documents with non-English locale. We use "," decimal delimiter in Russia. When I use your updated script 1295,84335 becomes 129584335.

@fghber
Copy link

fghber commented Jan 5, 2021

@ralphilius Thank you for sharing! I've applied your change and noticed that blank cells become #NUM! error.
This can be avoided using Number(data[row][column]) instead of parseFloat(data[row][column]) to do the actual conversion. This works better for me and might be helpful for others as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants