Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarketMap renamed to TileMap #744

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

MarketMap renamed to TileMap #744

wants to merge 8 commits into from

Conversation

ChakriCherukuri
Copy link
Member

  1. Renamed MarketMap to TileMap
  2. Tested code and all example notebooks

fixes #743

@SylvainCorlay
Copy link
Member

This looks good to me, although it is a backward-incompatible change.

We are probably going to tag a bug-fix patch release before moving forward with this.

SylvainCorlay
SylvainCorlay requested changes Oct 31, 2018
View reviewed changes
Copy link
Member

@SylvainCorlay SylvainCorlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the PR in "Request changes" so that it is not merged by accident in a backward-compatible release.

@ChakriCherukuri
Copy link
Member Author

@SylvainCorlay do you want me to add the MarketMap back (while keeping the TileMap) with deprecation warning?

@SylvainCorlay
Copy link
Member

I think it is fine as is. I just want to tag a conservative patch release very soon. Then we can start with breaking changes in master (theming, renamings, megamarks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainCorlay SylvainCorlay SylvainCorlay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename MarketMap to TileMap
2 participants
@ChakriCherukuri @SylvainCorlay