WIP: Added a more general ToolbarWidget #724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of an exploration of doing toolbars (for bqplot and ipyvolume) a different way.
By making a ToolbarWidget that is a container (it has a single child widget), it can create a view of that child widget and send it messages (save to png, fullscreen).
What is does now as well, is keep a list of Interacts, and the current index and current value, which can be linked to a ToggleButtons widgets. I think a more general approach of this is to have a 'WidgetList' widget, that will keep a list, an index, and a current widget.
cc @astrofrog
In the attached screenshot (or the toolbar notebook) I used the glue icon using this PR jupyter-widgets/ipywidgets#2182
Maybe we should talk about using/including/modifying these icons, for a uniform UI for bqplot/ipyvolume/glue-jupyter