Commit on change event and let browser handle undo of text inputs #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
force-pushed
the
859-commit-on-change-event-and-let-browser-handle-undo-of-text-inputs
branch
2 times, most recently
from
d2fb02e
to
6ad3361
Compare
barmac
force-pushed
the
859-commit-on-change-event-and-let-browser-handle-undo-of-text-inputs
branch
from
6ad3361
to
322233a
Compare
barmac
force-pushed
the
859-commit-on-change-event-and-let-browser-handle-undo-of-text-inputs
branch
from
7189156
to
dae3622
Compare
bpmn-io-tasks
bot
added
needs review
barmac
requested review from
a team,
philippfromme and
holygeek00
and removed request for
a team
|
@philippfromme Do you need any support with reviewing this? |
|
@barmac Just so I understand correctly: We're trying to make inputs behave like direct-editing, where a command is issued only once I close/blur the editor?
This is not the case for other inputs yet and we're okay with that?
|
|
Yes, that's the point of the PR. Right now I want to fix it in the boxed expression where I experienced the most annoying issues. |
barmac
deleted the
859-commit-on-change-event-and-let-browser-handle-undo-of-text-inputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #859