Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add records.sh logging library package #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andsens
Copy link

@andsens andsens commented Jun 13, 2023

Heyo 馃憢

Here's a submission for a logging library.
At our company we use a version of this library for quite a few scripts, so it's somewhat battle-tested. I've had to adjust a few things in order to make it publishable though, so it's not the exact same code (hence the 0.9.0 version in the repo).

Regardless, I thought it would make a nice addition to the index. Note that I have added the logging tag, which... I think makes sense? Else just let me know and I'll remove it.

@samlikins
Copy link
Member

Package addition looks legit!
However, if you could do one thing Anders; update the title field to just the package name without the prefacing namespace. That will make it align with the other packages. Awesome addition, thanks!

@andsens
Copy link
Author

andsens commented Jun 14, 2023

Thank you :-) And you got it. I also fixed the filename itself.

@jwerle jwerle requested a review from samlikins June 14, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants