Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Adding more coverage for filters #780

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[test] Adding more coverage for filters #780

wants to merge 1 commit into from

Conversation

josiah-roberts
Copy link

@josiah-roberts josiah-roberts commented Nov 25, 2023 •
edited

Related to #778

Test cases

  • Left-to-right filter count behavior
    • Verify that Faces has 15x <no face>
    • Unselect Keywords USA Road trip
    • Verify that Faces has 7x <no face>
  • Date filter behavior
    • Move slider to July 5, 2015
    • Verify that Keywords has 2x USA
  • Direct click behavior covered in prior tests
  • Toggle-only behavior
  • Missing data / mangled data behavior

@josiah-roberts josiah-roberts mentioned this pull request Nov 25, 2023
Open
1 task
@bpatrik
Copy link
Owner

bpatrik commented Nov 25, 2023

Thank you! Let me know when this is ready for merging.

@josiah-roberts
Copy link
Author

Thank you! Let me know when this is ready for merging.

Will do - likely won't be before next weekend. 🙏

@bpatrik
Copy link
Owner

bpatrik commented Apr 29, 2024

I will reject this PR in the following days due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josiah-roberts @bpatrik