-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logs): break line in diff view #195
Conversation
🦋 Changeset detectedLatest commit: 86b8214 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). eventcatalog-example – ./🔍 Inspect: https://vercel.com/davidboyne123/eventcatalog-example/F6mqiewRLGZygWR4repGFSfV1Co3 [Deployment for 86b8214 canceled] eventcatalog-docs – ./🔍 Inspect: https://vercel.com/davidboyne123/eventcatalog-docs/8yLBj8dfceeHxmCwYucH8Skr2A8B [Deployment for 86b8214 canceled] |
Thank you @donaldpipowitch ! |
@all-contributors add @donaldpipowitch bug code |
I've put up a pull request to add @donaldpipowitch! 🎉 |
Thank you |
Motivation
Fixes #183.
Have you read the Contributing Guidelines on pull requests?
Yes
If you're wondering what this piece of code is about:
It keeps the position of the
+
/-
prefix (see line 38 on the right side):Without it the prefix would be centered to the "line height" (which looks weird if there are a lot of line breaks) (see line 38 on the right side):
Other notes:
main
branch, but the project actually usesmaster
.