Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): break line in diff view #195

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

donaldpipowitch
Copy link
Contributor

@donaldpipowitch donaldpipowitch commented Feb 11, 2022

Motivation

Fixes #183.

Have you read the Contributing Guidelines on pull requests?

Yes


If you're wondering what this piece of code is about:

.d2h-diff-table .d2h-code-side-line {
  display: inline-grid;
  grid-auto-flow: column;
  grid-template-columns: auto 1fr;
  grid-gap: 0.6em;
  margin-bottom: 0.05em;
  padding-right: 4.2em;
}

It keeps the position of the +/- prefix (see line 38 on the right side):
image

Without it the prefix would be centered to the "line height" (which looks weird if there are a lot of line breaks) (see line 38 on the right side):
image


Other notes:

  • Kudos for the project, the Contributing instructions and having a useful default example. Everything is very easy to follow! 👍
  • The Contributing instructions mention a main branch, but the project actually uses master.

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2022

🦋 Changeset detected

Latest commit: 86b8214

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eventcatalog/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

eventcatalog-example – ./

🔍 Inspect: https://vercel.com/davidboyne123/eventcatalog-example/F6mqiewRLGZygWR4repGFSfV1Co3
✅ Preview: Canceled

[Deployment for 86b8214 canceled]

eventcatalog-docs – ./

🔍 Inspect: https://vercel.com/davidboyne123/eventcatalog-docs/8yLBj8dfceeHxmCwYucH8Skr2A8B
✅ Preview: Canceled

[Deployment for 86b8214 canceled]

@vercel vercel bot temporarily deployed to Preview – eventcatalog-example February 11, 2022 07:17 Inactive
@vercel vercel bot temporarily deployed to Preview – eventcatalog-docs February 11, 2022 07:17 Inactive
@vercel vercel bot temporarily deployed to Preview – eventcatalog-example February 14, 2022 08:02 Inactive
@vercel vercel bot temporarily deployed to Preview – eventcatalog-docs February 14, 2022 08:02 Inactive
@boyney123 boyney123 merged commit a6f5ae3 into boyney123:master Feb 15, 2022
@boyney123
Copy link
Owner

Thank you @donaldpipowitch !

@boyney123
Copy link
Owner

@all-contributors add @donaldpipowitch bug code

@allcontributors
Copy link
Contributor

@boyney123

I've put up a pull request to add @donaldpipowitch! 🎉

@github-actions github-actions bot mentioned this pull request Feb 15, 2022
@donaldpipowitch
Copy link
Contributor Author

Thank you♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON diff in chnagelog view can be larger than viewport
2 participants