Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E for DSync #2701

Merged
merged 55 commits into from May 23, 2024
Merged

E2E for DSync #2701

merged 55 commits into from May 23, 2024

Conversation

niwsa
Copy link
Member

@niwsa niwsa commented May 13, 2024

What does this PR do?

Adds e2e tests for DSync Providers: Azure and Okta. Can be expanded to more providers in future.

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests
  • New e2e tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@niwsa niwsa marked this pull request as ready for review May 22, 2024 16:12
@niwsa niwsa requested a review from a team May 22, 2024 16:12
@niwsa niwsa merged commit 9f4ddda into main May 23, 2024
5 checks passed
@niwsa niwsa deleted the dsync-e2e-tests branch May 23, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants