Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid printing secrets and update guides #67

Merged
merged 2 commits into from
May 31, 2024
Merged

chore: avoid printing secrets and update guides #67

merged 2 commits into from
May 31, 2024
+15 −13

Conversation

markusrf
Copy link
Contributor

  • Minor changes to the guides
  • Avoid printing secrets to the console when writing to key vault

@markusrf markusrf requested a review from a team as a code owner April 12, 2024 09:20
@markusrf markusrf changed the title Docs/update guides Avoid printing secrets and update guies Apr 12, 2024
netr0m
netr0m approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@netr0m netr0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@netr0m netr0m changed the title Avoid printing secrets and update guies Avoid printing secrets and update guides May 31, 2024
@netr0m netr0m changed the title Avoid printing secrets and update guides chore: avoid printing secrets and update guides May 31, 2024
@markusrf markusrf merged commit fd5cb71 into main May 31, 2024
@markusrf markusrf deleted the docs/update-guides branch May 31, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netr0m netr0m netr0m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markusrf @netr0m