Add support for "If-Modified-Since" and "Last-Modified" #224
Conversation
… "Last-Modified" For caching, of course!
| continue | ||
| } | ||
|
|
||
| modTime := fileStats.ModTime() |
There was a problem hiding this comment.
How it works for embedded files?
static.FS.Open(name) returns a file either from embedded or from the file system
I'm not sure that this point will be worked out correctly here.
misc/handlers.go
Outdated
|
|
||
| filesData = append(filesData, fileData{ | ||
| Content: file, | ||
| ModTime: modTime, |
There was a problem hiding this comment.
And where do we use this parameter?
As far as I can see, we define it, but we don't use it anywhere.
| if err != nil { | ||
| continue |
There was a problem hiding this comment.
If file open, but we can’t stat file, we will continue. But file still open
|
|
||
| filesData = append(filesData, file) | ||
|
|
||
| defer file.Close() |
There was a problem hiding this comment.
defer in for cycle it’s not good idea.
File will be close only on exit from func
| defer file.Close() | ||
| } | ||
|
|
||
| // Step 2: Check the "If-Modified-Since" header in the request |
There was a problem hiding this comment.
This header used in browser? Or we should specify it?
|
I did some research today on how this tag affects caching on the cloudflare side. |
Might be a fix for #222 , but might need some more testing. And maybe add support in a similar way for other static stuff in the project.
Tested in docker, seems to be working as expected.