Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenID Connect integration #149

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

assusdan
Copy link

@assusdan assusdan commented May 30, 2022

There is request for SSO technologies support (see #74). One of SSO variants is OpenID Connect. So, i decided to implement such integration.

This PR adds a lot of dependencies, so I may consider to rewrite some of used OIDC libraries in order to get rid of some deps.

@decentral1se decentral1se mentioned this pull request Aug 23, 2022
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One question: does the OidcProviderUri include the realm? e.g. https://mykeycloak.com/auth/realms/$MY-REALM/... I think it does, in which case, great! If not, can we customise it? I often have a few realms on my keycloak install and often not using the default "master" one.

Hoping this can be merged at some point in the neat future as I'd love to test it out.

Thanks for the work!

@assusdan
Copy link
Author

@decentral1se this MR is actually in precess of rewrite. I'm changing working with users a bit, for better support of multitenancy. Multiple OIDC providers will be also supported. I will ensure Keycloak setups work well, too.

However, this MR will not be merged until temperature in my city will lower, as I do not have air conditioning and its too hard to work right now.

@decentral1se
Copy link
Contributor

solidarity @assusdan and thanks for the update, will be v happy to test / review your work! hope things will cool down soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants