Merge branch 'fix/262/supervisor-crdt-delete' into integration

botsquad · Nov 6, 2023 · 2f8b02f · 2f8b02f
2 parents fdce5a0 + b69792b
commit 2f8b02f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/horde/dynamic_supervisor_impl.ex b/lib/horde/dynamic_supervisor_impl.ex
@@ -431,6 +431,7 @@ defmodule Horde.DynamicSupervisorImpl do
 
               case current_member do
                 %{status: :dead} ->
+                  DeltaCrdt.delete(crdt_name(state.name), {:process, child_spec.id}, :infinity)
                   {_response, state} = add_child(randomize_child_id(child_spec), state)
 
                   state

diff --git a/test/dynamic_supervisor_test.exs b/test/dynamic_supervisor_test.exs
@@ -446,6 +446,18 @@ defmodule DynamicSupervisorTest do
 
       Process.sleep(5000)
       assert_receive {:starting, 5000}, 100
+
+      # we have 2 supervised processes
+      processes = :sys.get_state(:horde_2_graceful).processes_by_id
+      assert Horde.TableUtils.size_of(processes) == 2
+
+      # peek into the remaining supervisor, getting the supervised pids
+      pids =
+        :sys.get_state(:horde_2_graceful).processes_by_id
+        |> :ets.tab2list()
+        |> Enum.map(&(elem(&1, 1) |> elem(2)))
+
+      assert Enum.all?(pids, &Process.alive?/1)
     end
   end