Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Explain how MaxItems is applied in more detail #3151

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

shepazon
Copy link
Contributor

@shepazon shepazon commented Apr 1, 2024

This update to the botocore docs adds to the paginators chapter information explaining that the CommonPrefixes list doesn't count toward the limit set by MaxItems, with example code.

A few other minor cleanup bits are also included.

@shepazon shepazon marked this pull request as draft April 1, 2024 19:45
@shepazon
Copy link
Contributor Author

shepazon commented Apr 1, 2024

Converted this to a draft. Forgot the editorial and translation steps because I've gotten out of the habit due to work on other guides.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (8fd0160) to head (f7079ed).
Report is 164 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3151   +/-   ##
========================================
  Coverage    93.14%   93.14%           
========================================
  Files           66       66           
  Lines        14237    14245    +8     
========================================
+ Hits         13261    13269    +8     
  Misses         976      976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shepazon
Copy link
Contributor Author

shepazon commented Apr 2, 2024

Edit request has been submitted. Once that's done I'll submit for L10n.

@shepazon
Copy link
Contributor Author

shepazon commented Apr 2, 2024

Edit has been approved. This is now ready to merge and deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants