Ignore credential_process when set to the empty string #3099
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rdctmeconomou
force-pushed
the
empty-credential-process
branch
3 times, most recently
from
ead7387
to
da4aa9b
Compare
rdctmeconomou
force-pushed
the
empty-credential-process
branch
from
da4aa9b
to
4a25388
Compare
rdctmeconomou
force-pushed
the
empty-credential-process
branch
from
4a25388
to
382da17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the fix to
botocore.credentials.ProcessProvider.load()described in #3098. I added a test that reproduced the bug. The test passes with my fix applied.Please note that linting fails in test code released as part of botocore 1.34.18. I didn't think it wise to modify anything outside the scope of my bug report but am happy to commit a style fix if necessary.