Accept proxy config via environment variables #2595
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes these settings easily configurable via environment variables.
|
Thanks @mogul for the PR. One issue with this PR is that those variable names are specific to S3. They would have to be generalized as they could apply to other services. Another thing is that we would need to collaborate with other SDKs if we're considering 'AWS_*' prefixed variable names. But first we want to get more community feedback on the issue you created. I’m going to set this PR to Draft but we can keep your issue open for tracking the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes these proxy settings easily configurable via environment variables.
See aws/aws-sdk#357 for context.