This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix kms with custom host #3834
Open
Fix kms with custom host #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2018 12:16
This fixes a bug when using a `KmsConnection` with a custom host value - for example, [FIPS endpoints](https://aws.amazon.com/compliance/fips/). Previously, kms would set the host header to the region endpoint, regardless of the actual host that would be used. That resulted in an `InvalidSignatureException` when making any call.
akud
force-pushed
the
fix_kms_with_custom_host
branch
from
4cb984c
to
b5c528b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when using a
KmsConnectionwith a custom host value -for example, FIPS endpoints.
Previously, kms would set the host header to the region endpoint,
regardless of the actual host that would be used. That resulted in an
InvalidSignatureExceptionwhen making any call.