This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fixes incorrect HmacAuthV4 header ordering #3824
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes incorrect header ordering in HmacAuthV4 * added test
Fix python 3 boto auth canonical sorting
gaudenz
added a commit
to cloudscale-ch/s3-tests
that referenced
this pull request
Feb 28, 2019
There is an unresolved bug in boto in the signature v4 signing code. The issue is that the ordering of the signed headers is wrong. See boto/boto#3749 boto/boto#3822 When applying the fix from boto/boto#3824 all these tests pass. Tag these tests with aws4_boto_header_ordering_bug so they can be skipped.
gaudenz
added a commit
to cloudscale-ch/s3-tests
that referenced
this pull request
Feb 28, 2019
There is an unresolved bug in boto in the signature v4 signing code. The issue is that the ordering of the signed headers is wrong. See boto/boto#3749 boto/boto#3822 When applying the fix from boto/boto#3824 all these tests pass. Tag these tests with aws4_boto_header_ordering_bug so they can be skipped.
gaudenz
added a commit
to cloudscale-ch/s3-tests
that referenced
this pull request
Aug 27, 2020
There is an unresolved bug in boto in the signature v4 signing code. The issue is that the ordering of the signed headers is wrong. See boto/boto#3749 boto/boto#3822 When applying the fix from boto/boto#3824 all these tests pass. Tag these tests with aws4_boto_header_ordering_bug so they can be skipped.
ctx
pushed a commit
to cloudscale-ch/s3-tests
that referenced
this pull request
Dec 7, 2022
There is an unresolved bug in boto in the signature v4 signing code. The issue is that the ordering of the signed headers is wrong. See boto/boto#3749 boto/boto#3822 When applying the fix from boto/boto#3824 all these tests pass. Tag these tests with aws4_boto_header_ordering_bug so they can be skipped.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header ordering was incorrect. The headers should be sorted based on the header name instead of the whole header strings.
More details about why the old sorting was incorrect and the expected behavior can be found in issue #3749.
Fixes #3822, #3749