Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Activate the tab before closing the browser. #89

Merged
merged 2 commits into from
May 8, 2023

Conversation

livia-macon
Copy link
Contributor

This implementation force an active tab to ensure proper cleanup of webdriver.

@hhslepicka
Copy link
Contributor

@livia-macon tests are failing. Could you check?

@livia-macon
Copy link
Contributor Author

@hhslepicka Yes, I checked. It is giving errors in the tests of the Wait file. Kayque asked me to wait for him to fix the undetected error, and then redo the tests. But on Friday, he didn't get back to me. Today I'm going to check with him.

@hhslepicka hhslepicka merged commit 4074f66 into main May 8, 2023
14 checks passed
@hhslepicka hhslepicka deleted the ENH/Improving-stop-browser-method branch May 8, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants