-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Enable execute undetected tests in macos #88
CI: Enable execute undetected tests in macos #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just one small optional observation. Feel free to merge once tests are passing and the comment is added.
self._others_configurations() | ||
self.set_screen_resolution() | ||
|
||
def _instantiate_driver(self, driver_class, func_def_options): | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend adding here a comment about why is this necessary and also add a TODO so we can refactor this in the future once the undetectable chromedriver gets fixed.
No description provided.