-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement binary path #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small request to validate the input.
We also need a documentation Pull Request to update the browser configuration section in order to highlight this new feature.
botcity/web/bot.py
Outdated
Args: | ||
binary_path (str): The binary path to be used. | ||
""" | ||
self._binary_path = pathlib.Path(binary_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to validate the binary_path
parameter to ensure that it exists and is a valid file before assigning it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small request to validate the input.
We also need a documentation Pull Request to update the browser configuration section in order to highlight this new feature.
Now you can pass the location of the binary you want to run.
This opens up possibilities:
Run any Chrome-based Browser (Brave, Vivaldi, OperaGX, Chrome Beta, etc.)
Run any Firefox Based Browser (Tor, LibreWolf, Firefox Beta)
(Warning: Tor needs some additional settings to connect to Tor Network first)