Make operator / a friend of string_path #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashtum
changed the title
|
@pdimov, Upon further consideration, I made the |
|
What are we trying to fix here? #24 and http://trac.cpp.al/trac10/ticket/12466? |
Yes. |
|
This is the preferred approach, yes. But it looks like we are missing a test for |
ashtum
force-pushed
the
add-operator-/-for-string_path-and-string
branch
from
872938a
to
6b16249
Compare
ashtum
changed the title
ashtum
commented
Dec 5, 2023
Comment on lines
+1029
to
+1036
| { | ||
| path p = path(T("key1")) / path(T("key2.key3")); | ||
| BOOST_TEST(pt.get<int>(p, 0) == 1); | ||
| } | ||
| { | ||
| path p = path(T("key1.key2")) / path(T("key3")); | ||
| BOOST_TEST(pt.get<int>(p, 0) == 1); | ||
| } |
There was a problem hiding this comment.
But it looks like we are missing a test for
p1 / p2withp1andp2both being paths.
@pdimov, Addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.