Unsafe access to accumulator data #323
Conversation
HDembinski
commented
Apr 27, 2021
•
HDembinski
commented
- Test this with downstream boost-histogram
|
@henryiii Before I change all accumulators in this way, we should try first whether this change works the way we expect in boost-histogram. I can try to make the changes to test this in boost-histogram. |
|
Can this be rebased on top of current develop? |
HDembinski
force-pushed
the
unsafe_access_accumulators
branch
from
db6e4c3
to
598a51f
Compare
|
@henryiii Rebased on develop as you requested |
HDembinski
force-pushed
the
unsafe_access_accumulators
branch
from
598a51f
to
6a5af14
Compare
|
Thanks, I'll work on this further soon - might be after Python 3.10 / pybind11 2.8 / Windows 11 though, all to be released next Monday. (I don't think Windows 11 affects me, but recently noticed it had the same release date as Python 3.10) First initial try showed it will take some work, but didn't get far enough for good feedback yet. |
HDembinski
force-pushed
the
develop
branch
3 times, most recently
from
90ebbe0
to
bf7712f
Compare
|
FYI, I did attempt this a little while ago, but it will take a bit of work to properly implement. Boost-histogram has to know the memory layout exactly, since it can cast between a block of Python memory to C++ without copy. Convincing pybind11 of this without access to the actual structure just requires manual work for things normally covered by macros. I'll try to get back to this in ~1 week. |
