Support AWS_S3_URL_PROTOCOL #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minnozz
force-pushed
the
s3-url-protocol
branch
2 times, most recently
from
ff3fa87
to
0b2d717
Compare
- Allow setting in .env - Default to PROTOCOL (same as before) - Propagate to django-storages so it generates the correct URLs in sass_src
Minnozz
force-pushed
the
s3-url-protocol
branch
from
0b2d717
to
bf5c08d
Compare
|
@bookwyrm-social/code-review this PR is ready for review |
dato
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
I've never used S3, but tried to review this to get things moving.
It isn't clear now, from .env.example, when AWS_S3_URL_PROTOCOL should be set. I tried to find some appropriate wording ("should be set if there's a mismatch with USE_HTTPS"?), but wasn't satisfied.
I only have one real question, below.
|
@dato Thanks for the review! I added a comment in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.envPROTOCOL(same as before)sass_src