Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export bookshelves and review date #3215

Merged
merged 2 commits into from Jan 17, 2024

Conversation

ccamara
Copy link
Contributor

@ccamara ccamara commented Jan 13, 2024

This PR fixes #2846 : export bookshelves to csv file and also addresses an issue with reviews imported from GoodReads, which were not displayed because for some reason I do not understand, they do not have content_raw but content.

As a side note, to do this PR I'm also testing my own installation of pre-commit (see #3212 )

@ccamara
Copy link
Contributor Author

ccamara commented Jan 13, 2024

@hughrun , I may need your help here. .bw-dev pytest is failing, and I'm not sure why. I thought it would be that the CSV I'm creating does not have the required fields, but I can't see what may be missing. I also think I added the right number of commas on line 72 and 74.

@hughrun hughrun merged commit 45d6f1f into bookwyrm-social:main Jan 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported CSV file does not seem to contain information on what shelf my books are on
2 participants