rfc: in-memory Celery backend for tests #3151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to easily configure an in-memory transport for tests.
At the moment, this doesn't have much of an effect since most task calls are mock'd out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of Redis is avoided in tests by mocking the
.delaymethod of relevant Celery tasks. An alternative would be to run tests with an in-memory Celery backend, and let task objects be created there.This PR implements this, but it doesn't touch any existing
patch('...')block. (I think it best to do that in a separate PR, if at all.)But from the moment this is merged, patch blocks would not be needed in new code.